-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add customerType tag #149
add customerType tag #149
Conversation
@@ -29,7 +29,6 @@ protected void onCreate(Bundle savedInstanceState) { | |||
// SENTRY Tag and Breadcrumb | |||
String activity = this.getClass().getSimpleName(); | |||
Sentry.setTag("activity", activity); | |||
Sentry.setTag("customerType", "enterprise"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed explicit customerType = enterprise tag from MainActivity transaction only
@@ -111,6 +111,9 @@ public void onCreate() { | |||
}); | |||
}); | |||
|
|||
String[] allCustomerTypes = {"medium-plan", "large-plan", "small-plan", "enterprise"}; | |||
String customerType = allCustomerTypes[(int) (Math.random() * 4)]; | |||
Sentry.setTag("customerType", customerType); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
customerType added to SentryAndroid.init()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #149 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 15 15
Lines 777 771 -6
Branches 43 43
=====================================
+ Misses 777 771 -6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
resolves #129